Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run Forkchoice::onBlock async in block importer #8820

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Nov 5, 2024

When importing a block, we end up having the state transition running synchronously due to how Forkchoice::onBlock is written. In this way we run it using an async runner, which then enables a true async block import which have downstream effect on block publishing:

block publishing now starts just after the EQUIVOCATION check, without synchronously waiting the state transition

2024-11-05 18:41:13.224	
Slow Block Publishing *** Slot: 2910506 start 887ms, block_publishing_initiated +3ms, blob_sidecars_publishing_initiated +21ms, blob_sidecars_imported +7ms, block_import_completed +283ms, complete +1ms total: 315ms

for reference this is the old flow:

2024-11-05 18:42:37.393	
Slow Block Publishing *** Slot: 2910513 start 853ms, blob_sidecars_imported +26ms, block_publishing_initiated +291ms, blob_sidecars_publishing_initiated +0ms, block_import_completed +44ms, complete +0ms total: 361ms

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr changed the title tmp run Forkchoice::onBlock async in block importer Nov 6, 2024
@tbenr tbenr marked this pull request as ready for review November 6, 2024 10:15
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr enabled auto-merge (squash) November 6, 2024 13:29
@tbenr tbenr merged commit 703f4d3 into Consensys:master Nov 6, 2024
16 of 17 checks passed
@tbenr tbenr deleted the tmp-traces branch November 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants