run Forkchoice::onBlock
async in block importer
#8820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a block, we end up having the state transition running synchronously due to how
Forkchoice::onBlock
is written. In this way we run it using an async runner, which then enables a true async block import which have downstream effect on block publishing:block publishing now starts just after the EQUIVOCATION check, without synchronously waiting the state transition
for reference this is the old flow:
Documentation
doc-change-required
label to this PR if updates are required.Changelog