Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and fix function signature computation, and optimize performance #127

Closed
wants to merge 5 commits into from

Conversation

vquelque
Copy link

@vquelque vquelque commented Feb 3, 2023

This PR follows the PR in solidity-workspace here. Note that before merging this PR, the new solidity-workspace package must be published, and the dependency in this package bumped, as some breaking changes were introduced in solidity-workspace. This PR focuses on fixing the function signature feature and improving the overall performance of the extension. Note that more work can be done to further improve the performances.

This PR has the following objectives:

  • It upgrades the feature that generates function signatures, so that the signatures are generated from the AST
  • It moves several features - such as the resolution of inherited identifiers - to solidity-workspace
  • It adds a debounce function to rate-limit the requests made to the parser
  • It refactors the CodeLenses, and the symbol provider, to optimize their performances
  • It has various smaller improvements intended to optimize the overall performance of the extension.

To enforce a consistent code style, the sources were formatted with Prettier.

@tintinweb tintinweb mentioned this pull request Feb 14, 2023
@tintinweb
Copy link
Member

included in #128

@tintinweb tintinweb closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants