Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI-3414] Add analytics_tags support #135

Merged
merged 2 commits into from
May 2, 2024
Merged

[CI-3414] Add analytics_tags support #135

merged 2 commits into from
May 2, 2024

Conversation

stanlp1
Copy link
Contributor

@stanlp1 stanlp1 commented Apr 24, 2024 •
edited
Loading

Adds two things.

  1. defaultAnalyticsTags to the config.
  2. analyticsTags param to some tracking functions.

defaultAnalyticsTags will be passed with every request if exists, will be merged with analyticsTags if exists.

@stanlp1 stanlp1 requested a review from a team April 24, 2024 20:49
crgee1
crgee1 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@crgee1 crgee1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crgee1 crgee1 merged commit d10ae34 into master May 2, 2024
1 check passed
@crgee1 crgee1 deleted the ci-3414-android-sdk-analytics-tags branch May 2, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crgee1 crgee1 crgee1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanlp1 @crgee1