Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI 3666] Change data type of labels #138

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[CI 3666] Change data type of labels #138

merged 1 commit into from
Jul 11, 2024

Conversation

crgee1
Copy link
Contributor

@crgee1 crgee1 commented Jul 10, 2024

This would throw an error

"labels": {
"__cnstrc_retail_media_grove": {}
}

@crgee1 crgee1 requested review from a team and jjl014 July 10, 2024 07:19
jjl014
jjl014 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@jjl014 jjl014 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Seems to work great from what I can tell 🚀

Thanks for working on this! ❤️

Let's reach out to Grove and get them to update to the latest version after we push this out. 👍

@crgee1 crgee1 merged commit 7960e38 into master Jul 11, 2024
1 check passed
@crgee1 crgee1 deleted the ci-3666-android-change-labels-data-type branch July 11, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjl014 jjl014 jjl014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crgee1 @jjl014