Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add share results modal callbacks #204

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Add share results modal callbacks #204

merged 2 commits into from
Oct 15, 2024

Conversation

mocca102
Copy link
Contributor

@mocca102 mocca102 commented Oct 9, 2024

  • callbacks
    • onShareResultsModalOpen
    • onShareResultsModalClose

@mocca102 mocca102 requested a review from a team as a code owner October 9, 2024 18:50
esezen
esezen approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Mudaafi
Mudaafi approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocca102 mocca102 merged commit 3d3aa77 into main Oct 15, 2024
11 checks passed
@mocca102 mocca102 deleted the ci-3891-os-ui-quizzes-add-callback-for-modal-open-and-modal-close-to branch October 15, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esezen esezen esezen approved these changes

@Mudaafi Mudaafi Mudaafi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mocca102 @esezen @Mudaafi