Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build java version to 16 #105

Closed
wants to merge 5 commits into from

Conversation

bryanateoan
Copy link
Contributor

@bryanateoan bryanateoan commented Aug 27, 2021

Looks like temurin only has 8, 11, and 16. Java 16 is not compatible with the latest versions of spotless and javadoc plugins. spotless has a workaround but we can't use it since we are targeting java 8.

Setting the build workflow to use 11, until our dependencies get updated to 16.

@bryanateoan
Copy link
Contributor Author

Converting to draft. Looks like spotless has issues with jdk 16 diffplug/spotless#834
tried with 2.12.3 and still get the same error.

@bryanateoan bryanateoan marked this pull request as draft August 27, 2021 22:26
@bryanateoan bryanateoan marked this pull request as ready for review August 27, 2021 23:38
@gilday
Copy link
Contributor

gilday commented Aug 30, 2021

We can workaround the Spotless issue, but I have no solution for the incompatibility with the doclet we're using for code samples

<docletArtifact>
  <groupId>org.apidesign.javadoc</groupId>
  <artifactId>codesnippet-doclet</artifactId>
  <version>0.61</version>
</docletArtifact>

It's using internal classes that have been hidden in JDK 16.

There's a JEP for introducing code snippets to the javadoc tool natively (see https://bugs.openjdk.java.net/browse/JDK-8201533). It's slated for JDK 18. I recommend we use only JDK 11 in our build chain (continuing to target JDK 1.8 with the --release javac flag) until JDK 18 at which time we can use the native code snippet support.

@gilday gilday deleted the update-build-java-version-to-16 branch September 16, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants