Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added filter issue by open or close status #189

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

hexwhiz
Copy link
Contributor

@hexwhiz hexwhiz commented Oct 24, 2024

Description

Added a new dropdown submenu in the filter option to filter issues based on their open or close status using a new view filter_by_status. Also fixed alignment of the submenus in the filter dropdown.

Related Issue

Fixes #188

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motivation and Context

Screenshots (if appropriate):

2024-10-25.00-23-22.mp4

Checklist:

  • I have registered myself at Contrihub website.
  • My code follows the code style of this project.
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • Any dependent changes have been merged and published in downstream modules
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

@meisabhishekpatel
Copy link
Contributor

@hexwhiz automated testing fails...

@hexwhiz
Copy link
Contributor Author

hexwhiz commented Oct 25, 2024

Didn't ran the flake8 test. I will commit again after the check.

@meisabhishekpatel meisabhishekpatel dismissed their stale review October 25, 2024 15:59

automated test fails

@hexwhiz
Copy link
Contributor Author

hexwhiz commented Oct 25, 2024

@meisabhishekpatel done making changes. Now the test should pass

@meisabhishekpatel
Copy link
Contributor

closes #189

@meisabhishekpatel meisabhishekpatel merged commit 14a8847 into ContriHUB:main Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Issues by Status for Easier Contribution
2 participants