-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create FreeBSD-specific Makefile #456
Open
lattera
wants to merge
9
commits into
CopernicaMarketingSoftware:master
Choose a base branch
from
lattera:blackhawknest/ports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create FreeBSD-specific Makefile #456
lattera
wants to merge
9
commits into
CopernicaMarketingSoftware:master
from
lattera:blackhawknest/ports
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Third-party applications on FreeBSD/HardenedBSD install into /usr/local. Signed-off-by: Shawn Webb <swebb@blackhawknest.com> Sponsored-by: BlackhawkNest, Inc
Signed-off-by: Shawn Webb <swebb@blackhawknest.com> Sponsored-by: BlackhawkNest, Inc
Signed-off-by: Shawn Webb <swebb@blackhawknest.com> Sponsored-by: BlackhawkNest, Inc
Signed-off-by: Shawn Webb <swebb@blackhawknest.com> Sponsored-by: BlackhawkNest, Inc
Since I created a FreeBSD-specific Makefile, there's no need to modify the primary Makefile. Signed-off-by: Shawn Webb <swebb@blackhawknest.com> Sponsored-by: BlackhawkNest, Inc
Also, default to /usr/local if PREFIX is undefined. Signed-off-by: Shawn Webb <swebb@blackhawknest.com>
Signed-off-by: Shawn Webb <swebb@blackhawknest.com>
When telling the BSD build infrastructure where to find source code files, the order matters. In this repo, there are some source code files with the same file name that live in /common and /zend. For example, /common/streambuf.cpp and /zend/streambuf.cpp. It seams that the former is scaffolding while the latter is the complete implementation. With this fix, PHP is able to load a custom extension that builds on top of PHP-CPP. PHP Warning: PHP Startup: Unable to load dynamic library '/usr/home/shawn/projects/php-lib[sanitized]/obj/libphp-lib[sanitized].so' (tried: /usr /home/shawn/projects/php-lib[sanitized]/obj/libphp-lib[sanitized].so (/usr/local/lib/libphpcpp.so.2.2.0: Undefined symbol "_ZN3Php9StreamBuf4sync Ev"), /usr/local/lib/php/20190902//usr/home/shawn/projects/php-lib[sanitized]/obj/libphp-lib[sanitized].so.so (Cannot open "/usr/local/lib/php/20 190902//usr/home/shawn/projects/php-lib[sanitized]/obj/libphp-lib[sanitized].so.so")) in Unknown on line 0 Signed-off-by: Shawn Webb <swebb@blackhawknest.com>
Rename /common/streambuf.cpp to /common/common_streambuf.cpp to address file name conflict with /zend/streambuf.cpp. Signed-off-by: Shawn Webb <swebb@blackhawknest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Makefile.FreeBSD
that is friendly with the bsdmake framework. This allows for easy integration into the FreeBSD ports tree.Sponsored-by: BlackhawkNest, Inc