Allow i18n of colander error messages #206
Conversation
| @@ -32,6 +33,17 @@ def add_apidoc(config, pattern, func, service, **kwargs): | |||
| info['func'] = func | |||
|
|
|||
|
|
|||
| def set_localizer_for_languages(event, available_languages, | |||
There was a problem hiding this comment.
Could you add a docstring here?
|
This approach seems reasonable to me. |
|
Good work :) |
|
Regarding lazily setting up localization, do you say that for performance reasons? I suppose that instead of setting a localizer for every request, we could set it up only in the case where there are validation errors. Would that be better? Couple of changes I just did:
FYI, a colander maintainer seems favorable to my pull request Pylons/colander#157 Hopefully it will get merged soon, but you probably cannot merge the current pull request until a new version of Colander including that change is released on PyPI. |
|
The required Colander change has been merged to master. Now waiting for the next Colander release before we can consider merging this pull request. |
|
I hadn't seen this PR, and had some of this stuff re-implemented into Daybed : spiral-project/daybed#258 Alex's code is a lot better :) and it makes of course more sense to assemble all these in Cornice instead of Daybed :) |
|
There's been a new colander release about a month ago, but my change hasn't been included in it. It's still in the next release feature list. |
|
It look like it has been merged. Can we rebase that code and get it merged? |
|
@Natim Colander changes have been merged but not released yet. Scheduled for next release according to https://github.com/Pylons/colander/blob/master/CHANGES.rst I just rebased this PR to keep it in sync with master (had a couple of minor conflicts) but it still cannot be merged until required Colander changes get released. |
|
Colander 1.1 has been released on PyPI, with Pylons/colander#157 merged. |
|
Thank you guys :) |
ghost
changed the title
|
I just rebased on master, resolved conflicts and pushed. I'm not sure why GitHub says it has conflicts. I just tried manually merging this branch into master and it had no conflicts. @Natim How does it look on your end? |
|
From github's Pull Request page, it looks like you merged master instead of rebasing the originale commits:
|
|
Maybe you forgot to update your local master branch before rebasing your pull request onto master?
Furthermore, I think you should drop the "Update documentation version number" makinacorpus/cornice@186fd8b and leave alone docs/source/conf.py . |
ghost
force-pushed
the
colander-i18n
branch
2 times, most recently
from
b6a2a40
to
a5f3234
Compare
|
@lmctv Thanks a lot, I totally forgot to update my local master before rebasing. Should be fine to merge now. |
| To enable localization of Colander error messages, you must set | ||
| `available_languages <http://docs.pylonsproject.org/projects/pyramid/en/1.3-branch/narr/i18n.html#detecting-available-languages>`_ in your settings. | ||
| You may also set `pyramid.default_locale_name <http://docs.pylonsproject.org/projects/pyramid/en/1.3-branch/narr/environment.html#default-locale-name-setting>`_. | ||
|
|
There was a problem hiding this comment.
IMHO, you should refer to
http://docs.pylonsproject.org/projects/pyramid/en/latest/narr/i18n.html#detecting-available-languages
and
http://docs.pylonsproject.org/projects/pyramid/en/latest/narr/environment.html#default-locale-name-setting
or update 1.3 -> 1.6
Allow i18n of colander error messages
|
Thansk @amarandon |
|
This was a loooong wait. Thanks again. |
Remove superfluous call to get_localizer (ref #206)
Fix #200
After investigating the issue further, I realized that not everything can be done by Colander. Colander can only provide translation strings but it cannot perform the translation itself because it doesn't depend on Pyramid and doesn't know about localizers. As suggested earlier, I've proposed a change to Colander so that we can pass a translation callable to the
asdictmethod: Pylons/colander#157However it's still up to Cornice to provide a callback that is aware of the current locale.
Since Cornice aims at following HTTP conventions, I've added support for the HTTP
Accept-Languageheader. I've also added some configuration code that sets up a localizer depending on configuration variables based on suggestions from the Pyramid documentation:pyramid.default_locale_nameto specify the default localeavailable_languagesto specify the list of available languages