-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding abillity to define services imperative #335
Conversation
@@ -30,6 +30,24 @@ Here is how you can register a resource:: | |||
_USERS[len(_USERS) + 1] = self.request.json_body | |||
return True | |||
|
|||
Here a example of imperative way defining a resource:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider: "Here is an example of how to define cornice resources in an imperative way"
Hi! Thanks for taking the time to submit this pull request. That's appreciated. I like how the decorators are now completely optional, and in some way, it closes the gap I started to fill when I did the cornice refactor. I'm not a big fan of the I've added a few comments and I think we're good for merging once they're addressed. |
adding ametaireau changes extended sphinx tests for resource
Hi, i've added the directive |
Do you had some time to look into that? |
@leplatrem could you also take a look into that pull request |
Hey Josip, this looks really good. Eveything is in there: impelmentation, docs, new tests, plus the old tests are passing. Let's merge :-) |
adding abillity to define services imperative
Wonderful do you know if someone is already working on the push request #285 ? If not i will look into that one next week. |
Neat. Nobody is currently working on this I believe. Feel free to take it! |
See issue #334 for more info. Coverage for sphinxext increased to 60% :)