Fix Access-Control-Max-Age value if undefined on service #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
r+ |
| for meth, view, args in self.definitions: | ||
| if method and meth.upper() == method.upper(): | ||
| return args.get('cors_max_age', False) | ||
| max_age = args.get('cors_max_age', None) |
There was a problem hiding this comment.
we should break here to avoid continue the for loop. Only the first value matters.
leplatrem
force-pushed
the
fix-max-age-if-undefined
branch
from
6d8e24d
to
035387e
Compare
almet
added a commit
that referenced
this pull request
Sep 28, 2015
Fix Access-Control-Max-Age value if undefined on service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the header is always present a
Falsevalue.