-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly handle content_type callables returning a single internet media type as scalar #350
Conversation
@@ -1,5 +1,7 @@ | |||
.tox | |||
.hg* | |||
.venv* | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this? (should it be part of your .gitignore instead?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.idea
is the project metadata folder of PyCharm, which is in pretty common use amongst our folks.- When working with python virtualenvs, i think it is a convention to use
.venv27
or.venv34
folders for designating the type of virtualenv. Given, when using tox one usually doesn't need manual-made virtualenvs for running the tests, but we usually even install tox into a project-local virtualenv to completely decouple from the system python.
Both entries shouldn't do any harm but instead should gain value for others, so they were added on purpose. However, we can remove them again if they make anyone sad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these two lines should not be included because they're specific to one setup. It would make this file harder to maintain over time, for little benefit :-)
Hi, and thanks for doing this! I've put a bunch of comments here and there, let me know when you had the time to address them! |
Hey Alex, thanks for reviewing this. Will answer the comments inline. |
Hi Alex, i tried to clarify my intentions and give an outlook. Let me know if there's still any blocking issue for you in this, otherwise i would appreciate doing a different PR for more cosmetic and cleanup work centered around the things mentioned. Best, Andreas. |
I think we're good once the .gitignore lines have been removed! |
…dia type as scalar, improves and resolves Cornices#343
0390a20
to
3a74866
Compare
Thanks! The .gitignore lines have been removed by a squashed commit. |
Thanks! |
properly handle content_type callables returning a single internet media type as scalar
Thanks for merging! Would you also have a look at #351? This complements this change as it improves and clarifies the documentation regarding this topic at the places @bomb-on and @leplatrem were looking at in the context of #343. |
Improve and resolve #343, add appropriate tests.