Only accept known locations in request.errors.add() (fixes #99) #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I see in #376, it should probably also support |
leplatrem
force-pushed
the
99-check-errors-location
branch
from
3527260
to
df488a4
Compare
|
@Natim r? |
Natim
requested changes
Oct 19, 2016
|
|
||
| def test_raises_an_exception_when_location_is_unsupported(self): | ||
| with self.assertRaises(ValueError): | ||
| self.errors.add('something') |
There was a problem hiding this comment.
Can we add tests for each accepted parameters?
Natim
reviewed
Oct 19, 2016
| @@ -18,7 +18,7 @@ def add(self, location, name=None, description=None, **kw): | |||
| """Registers a new error.""" | |||
| allowed = ('body', 'querystring', 'url', 'header', 'path', | |||
| 'cookies', 'method') | |||
| if location not in allowed: | |||
| if location != '' and location not in allowed: | |||
There was a problem hiding this comment.
Do you really want to accept empty location?
Natim
reviewed
Oct 19, 2016
| @@ -16,6 +16,11 @@ def __init__(self, status=400): | |||
|
|
|||
| def add(self, location, name=None, description=None, **kw): | |||
| """Registers a new error.""" | |||
| allowed = ('body', 'querystring', 'url', 'header', 'path', | |||
| 'cookies', 'method') | |||
| if location != '' and location not in allowed: | |||
There was a problem hiding this comment.
Do you really want to accept empty location?
There was a problem hiding this comment.
That's what colander gives when you raise a validation error that is not related to a specific node (eg. provide param either via header or querystring)
Natim
approved these changes
Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this conflicts with your PR @tarekziade, do not take it into account, I'll rebase it later.
r?