core/types: fix and test handling of faulty nil-returning signer

CortexFoundation · Jan 27, 2024 · 367684b · 367684b
1 parent 9849c6f
commit 367684b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/core/types/transaction.go b/core/types/transaction.go
@@ -19,6 +19,7 @@ package types
 import (
 	"container/heap"
 	"errors"
+	"fmt"
 	"io"
 	"math/big"
 	"sync/atomic"
@@ -237,6 +238,9 @@ func (tx *Transaction) WithSignature(signer Signer, sig []byte) (*Transaction, e
 	if err != nil {
 		return nil, err
 	}
+	if r == nil || s == nil || v == nil {
+		return nil, fmt.Errorf("%w: r: %s, s: %s, v: %s", ErrInvalidSig, r, s, v)
+	}
 	cpy := &Transaction{
 		data: tx.data,
 		time: tx.time,