Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics usage & refactor #1719

Merged
merged 1 commit into from
Sep 14, 2023
Merged

metrics usage & refactor #1719

merged 1 commit into from
Sep 14, 2023

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Sep 14, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1719 (65a1922) into master (5802a7b) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 61.89%.

❗ Current head 65a1922 differs from pull request most recent head b513b10. Consider uploading reports for the commit b513b10 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
+ Coverage   52.76%   52.78%   +0.01%     
==========================================
  Files         484      485       +1     
  Lines       60657    60366     -291     
==========================================
- Hits        32007    31862     -145     
+ Misses      26210    26067     -143     
+ Partials     2440     2437       -3     
Files Changed Coverage Δ
consensus/cuckoo/cuckoo.go 35.78% <0.00%> (ø)
metrics/graphite.go 0.00% <0.00%> (ø)
metrics/inactive.go 0.00% <0.00%> (ø)
metrics/internal/sampledata.go 0.00% <0.00%> (ø)
metrics/log.go 0.00% <0.00%> (ø)
metrics/metrics.go 26.85% <0.00%> (-1.04%) ⬇️
metrics/resetting_sample.go 0.00% <0.00%> (ø)
metrics/syslog.go 0.00% <0.00%> (ø)
metrics/writer.go 2.77% <0.00%> (ø)
metrics/gauge.go 37.14% <20.00%> (-7.50%) ⬇️
... and 16 more

... and 14 files with indirect coverage changes

@ucwong ucwong changed the title metrics usage metrics usage & refactor Sep 14, 2023
@ucwong ucwong merged commit cfb1075 into master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant