Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmwasm-schema] make deny_unknown_fields optional #2019

Closed
lvn-ryu opened this issue Feb 7, 2024 · 1 comment · Fixed by #2080
Closed

[cosmwasm-schema] make deny_unknown_fields optional #2019

lvn-ryu opened this issue Feb 7, 2024 · 1 comment · Fixed by #2080
Assignees
Milestone

Comments

@lvn-ryu
Copy link

lvn-ryu commented Feb 7, 2024

See #2017 (comment) for suggested implementation

@webmaster128
Copy link
Member

webmaster128 commented Mar 27, 2024

@aumetra could you have a look into that?

I think we should ensure NOT to set deny_unknown_fields for the deserializer. If we need to make modufications to the JSON Schema, those should be done in post-processing after schemars. Making undesired deserializer configurations for the sale of better TS types is the wrong priorization.

We'd need to revert parts of #1307 and move the removal of {[k: string]: unknown} in TypeScript to a later point in the process.

@webmaster128 webmaster128 added this to the 2.1.0 milestone Mar 27, 2024
@aumetra aumetra self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants