-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly allow unknown fields #2080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as the major step.
Now do you think you can turn off additional_properties
(somewhere in the schemars types) at a later stage, maybe here?
impl Api {
pub fn render(self) -> JsonApi {
Let's see if this does the trick |
7609267
to
bcae345
Compare
@webmaster128 this solution now generates more |
Pretty good I think. The changes I see after generating this branch locally: |
Great! Then I'll look into updating the schemas later |
Nice. Could you add a CHANGELOG entry for this? |
00fc3f6
to
48a6d5e
Compare
Looked over my PRs again and discovered some missing changelog entries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Closes #2019