Uint256 implementation #1059
Merged
Uint256 implementation #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the commends have been addressed! |
| } | ||
|
|
||
| /// Multiplies two u128 values without overflow. | ||
| fn full_mul(self, rhs: impl Into<u128>) -> U256 { | ||
| U256::from(self.u128()) * U256::from(rhs.into()) | ||
| pub fn full_mul(self, rhs: impl Into<u128>) -> Uint256 { |
There was a problem hiding this comment.
This new API is nice. Could you add a CHANGELOG entry and an example doc for it?
| @@ -4,6 +4,9 @@ mod system_error; | |||
| mod verification_error; | |||
|
|
|||
| pub use recover_pubkey_error::RecoverPubkeyError; | |||
| pub use std_error::{DivideByZeroError, OverflowError, OverflowOperation, StdError, StdResult}; | |||
| pub use std_error::{ | |||
| ConversionOverflowError, DivideByZeroError, OverflowError, OverflowOperation, StdError, | |||
There was a problem hiding this comment.
ConversionOverflowError also need to be exported in lib.rs because it is used in StdError now.
maurolacy
reviewed
Aug 30, 2021
| panic!( | ||
| "right shift error: {} is larger than the number of bits in Uint256", | ||
| "right shift error: {} is larger or equal than the number of bits in Uint256", |
There was a problem hiding this comment.
👍🏼 This is being handled in the other impls by delegating to the checked variant and unwrapping. Nice to have consistent behaviour here.
What about a checked_shr, by the way? I guess it's not currently needed / used. But wouldn't be bad to have; particularly because it doesn't panic.
webmaster128
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes
Isqrtimplementation forUint64,Uint128andUint256.Closes #1053
Closes #1054