Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try latest Wasmer with singlepass on Windows #1138

Merged
merged 8 commits into from
Dec 14, 2021
Merged

Try latest Wasmer with singlepass on Windows #1138

merged 8 commits into from
Dec 14, 2021

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Oct 13, 2021 •
edited
Loading

Follow-up of #834

Closes #649

This was referenced Oct 14, 2021
Merged
Merged
@webmaster128 webmaster128 mentioned this pull request Nov 9, 2021
Closed
@uint uint force-pushed the default-to-singlepass-next-try branch from 5de3055 to 03e1ff5 Compare December 8, 2021 13:47
@uint
Copy link
Contributor

uint commented Dec 8, 2021

Rebased and bumped wasmer to 2.1.0

@uint uint marked this pull request as ready for review December 8, 2021 14:22
@uint uint requested a review from maurolacy December 8, 2021 14:22
@uint
Copy link
Contributor

uint commented Dec 8, 2021

@webmaster128 seems to be working at wasmer 2.1.0! Can't mark you as reviewer obviously.

webmaster128
webmaster128 commented Dec 8, 2021
View reviewed changes
Copy link
Member Author

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you add a CHANGELOG entry for that?

packages/profiler/Cargo.toml Outdated Show resolved Hide resolved
uint and others added 3 commits December 8, 2021 15:29
@uint @webmaster128
profiler/Cargo.toml style
ce65bda 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@uint
CHANGELOG update
5962496
@uint
format
80e65ff
webmaster128
webmaster128 commented Dec 8, 2021
View reviewed changes
Copy link
Member Author

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (cannot approve).

Would love to get @maurolacy's 👀 on here as well

@uint uint self-requested a review December 8, 2021 16:07
maurolacy
maurolacy approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was going to comment on porting the other contracts as well, and then saw the branch name.

On second thought, and just in case, what about the other contracts besides hackatom using singlepass too?

@webmaster128 webmaster128 merged commit 0970e14 into main Dec 14, 2021
@webmaster128 webmaster128 deleted the default-to-singlepass-next-try branch December 14, 2021 09:47
@webmaster128
Copy link
Member Author

On second thought, and just in case, what about the other contracts besides hackatom using singlepass too?

Pulled out into #1179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uint uint uint approved these changes

@maurolacy maurolacy maurolacy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use OS specific default backend in integration tests
3 participants
@webmaster128 @uint @maurolacy