Decimal checked multiplication and exponentiation #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
approved these changes
Mar 10, 2022
| (Decimal::permille(6), Decimal::permille(13)), | ||
| ]; | ||
|
|
||
| // The regular std::ops::Mul is our source of truth for these tests. |
packages/std/src/math/decimal.rs
Outdated
| assert_eq!(Decimal::one().checked_pow(exp).unwrap(), Decimal::one()); | ||
| } | ||
|
|
||
| // Do we leave 0^0 undefined? |
There was a problem hiding this comment.
What about going with the Rust standard library behaviour of expecting 1 in the implementation, even though this is mathematically undefined.
|
Added this to #1186. If you're in the mood to finish the checked_pow row, I'd appreciate that. |
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
webmaster128
approved these changes
Mar 10, 2022
Not today, but I'll take a look between other work. Nice to change things up a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time no PR! Bringing some math with me here.