Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement msg macro to simplify configuring serialization #1345

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Implement msg macro to simplify configuring serialization #1345

merged 9 commits into from
Jul 12, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Jul 11, 2022 •
edited
Loading

Closes #1307 by implementing this suggestion.

Builds on top of #1339

@uint uint force-pushed the cosmwasm-msg-attr-macro branch from e6086b7 to a1ed27f Compare July 11, 2022 13:51
Base automatically changed from idl-ux to main July 11, 2022 14:40
@uint uint marked this pull request as ready for review July 11, 2022 15:43
This was referenced Jul 11, 2022
Closed
Merged
pyramation
pyramation approved these changes Jul 11, 2022
View reviewed changes
Copy link

@pyramation pyramation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow great work. I love how many lines can be deleted here. I think that's a sign (at least to me) that this is a great macro!

webmaster128
webmaster128 reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I'm just wondering if msg is a great name for both messages and query responses … But I don't have a good answer or better idea right now.

packages/schema-derive/src/msg.rs Outdated Show resolved Hide resolved
packages/schema/src/lib.rs Outdated Show resolved Hide resolved
@uint
Copy link
Contributor Author

uint commented Jul 12, 2022

I'm just wondering if msg is a great name for both messages and query responses … But I don't have a good answer or better idea right now.

Yeah, and I think this will also be used for arbitrary other types that happen to be included in any messages/responses. Other ideas: cw_serde, cw_serialize, send, sendable?

@webmaster128
Copy link
Member

I like cw_serde. It's a bit technical but at least not misleading. Since this is copy/pasted all the time, there will not be much need to remember the name.

@uint
Copy link
Contributor Author

uint commented Jul 12, 2022

Added a MIGRATING.md entry!

webmaster128
webmaster128 reviewed Jul 12, 2022
View reviewed changes
MIGRATING.md Outdated Show resolved Hide resolved
MIGRATING.md Outdated Show resolved Hide resolved
uint and others added 2 commits July 12, 2022 15:13
@uint @webmaster128
Update MIGRATING.md with new version number
aeec617 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@uint
MIGRATING.md update
e117fea
@uint uint requested a review from webmaster128 July 12, 2022 13:21
@webmaster128 webmaster128 added this to the 1.1.0 milestone Jul 12, 2022
@uint uint merged commit e807a62 into main Jul 12, 2022
@uint uint deleted the cosmwasm-msg-attr-macro branch July 12, 2022 14:44
@da1suk8 da1suk8 mentioned this pull request Aug 2, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@pyramation pyramation pyramation approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Remove additional properties in schema generation
3 participants
@uint @webmaster128 @pyramation