Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generics + nestedness in QueryMsg #1520

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Fix generics + nestedness in QueryMsg #1520

merged 6 commits into from
Nov 29, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Nov 28, 2022

  • Fixes and closes Generics support for QueryResponses derive macro #1516
  • Doc comments in nested QueryMsg with generics caused schema gen errors (failed integrity check due to different schema structure). I removed the integrity check altogether. JSON Schema can represent the same Rust types in various ways and accounting for every possibility would just be maintenance hell. The representation could also change between versions of schemars and is pretty much its implementation detail.

webmaster128
webmaster128 reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you target the 1.1 branch and make a 1.1.x release with that patch?

packages/schema/Cargo.toml Outdated
@@ -16,5 +16,6 @@ thiserror = "1.0.13"

[dev-dependencies]
anyhow = "1.0.57"
cosmwasm-std = "1.1.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we need the internal dependency style with the path argument. Otherwise we get duplicate dependencies (see lockfile diff)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad

@uint
Copy link
Contributor Author

uint commented Nov 29, 2022

Nice! Could you target the 1.1 branch and make a 1.1.x release with that patch?

Is that really needed though? I don't think this is a regression.

@webmaster128
Copy link
Member

Is that really needed though? I don't think this is a regression.

okay, good. 1.2. will be out soon. I just thought it classifies as a bug. But we can also call it missing feature.

webmaster128
webmaster128 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 great stuff

@uint uint merged commit 43cbe24 into main Nov 29, 2022
@uint uint deleted the generics-fix branch November 29, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generics support for QueryResponses derive macro
2 participants
@uint @webmaster128