Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Add BankQuery::AllDenomMetadata gated by cosmwasm_1_3 feature flag #1647

Closed
wants to merge 2 commits into from

Conversation

nik-suri
Copy link
Contributor

@nik-suri nik-suri commented Mar 24, 2023

This PR adds a new query for getting chain denom metadata.

Please review these related PRs in tandem:

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 💐 I have added some notes coming from wasmd.
It would be good to understand your use case better to discuss solutions.

packages/std/src/query/bank.rs Outdated Show resolved Hide resolved
packages/std/src/metadata.rs Outdated Show resolved Hide resolved
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Great work, thank you!

MIGRATING.md Outdated Show resolved Hide resolved
packages/std/src/query/bank.rs Outdated Show resolved Hide resolved
@chipshort
Copy link
Collaborator

Thanks for the great work, I'll work on this a bit more in #1703, as well as CosmWasm/wasmvm#430 and CosmWasm/wasmd#1426

@nik-suri
Copy link
Contributor Author

nik-suri commented Jun 7, 2023

Thanks so much for pulling in my commits and building off these changes @chipshort and @webmaster128! I will close these PRs.

Closing in favor of #1703.

@nik-suri nik-suri closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants