Cosmwasm-check: update clap to version 4 #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babadro
force-pushed
the
1518-cosmwasm-check-clap-v4
branch
2 times, most recently
from
a6a5019
to
1919095
Compare
chipshort
reviewed
May 2, 2023
babadro
force-pushed
the
1518-cosmwasm-check-clap-v4
branch
from
311aecd
to
99bd9c2
Compare
maurolacy
reviewed
May 3, 2023
Comment on lines
+42
to
+43
| .get_one::<String>("CAPABILITIES") | ||
| .map(|s| s.as_str()) |
There was a problem hiding this comment.
Curious construct; but it works.
babadro
force-pushed
the
1518-cosmwasm-check-clap-v4
branch
2 times, most recently
from
cec8123
to
657d7f6
Compare
chipshort
reviewed
May 17, 2023
|
@babadro Could you resolve the changelog conflict and add the PR link to the changelog entry? (see the other entries) |
chipshort
force-pushed
the
1518-cosmwasm-check-clap-v4
branch
from
657d7f6
to
433f570
Compare
|
We just wrapped up the work to get it merged. Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1518
cosmwasm-check: