Coin uses shorter format for Debug #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be good to use a different format for the debug view. For example, if the denom is empty, this would just output a number. Also, I think it would be nice to keep the type in there, such that the debug output of the |
|
|
chipshort
reviewed
Jun 6, 2023
ethanfrey
force-pushed
the
better-debug-coin
branch
from
0277e27
to
52ccdad
Compare
|
I made the suggested changes and rebased on main |
ethanfrey
changed the title
webmaster128
reviewed
Jun 7, 2023
|
Backported and shipped as part of 1.2.7 (#1719) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Display is now like
123ucosmwhile Debug is likeCoin { denom: "ucosm", amount: Uint128(123) }](See example here: #1257).This is quite annoying when outputing Debug for larger structs that include
Vec<Coin>. Now the binary fields are well-encoded, this is the ugliest part of debugging view.This will just align the Debug view with the Display view (as this seems like the canonical encoding format as per #1684)
Update: We agreed on
Coin { 123 "ucosm" }as a more correct, yet still compact, encoding