Use wasmparser instead of parity-wasm #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
force-pushed
the
1735-wasmparser
branch
from
f118d14
to
2d4aac7
Compare
chipshort
force-pushed
the
1735-wasmparser
branch
from
e39f720
to
524e2d9
Compare
| multi_memory: false, | ||
| memory64: false, | ||
| ..Default::default() | ||
| }); |
There was a problem hiding this comment.
Looks good. During parsing we can be a bit more open wrt. Wasm features/extensions. They will be disallowed by the middleware.
chipshort
force-pushed
the
1735-wasmparser
branch
from
df32812
to
55cfdf1
Compare
webmaster128
approved these changes
Jul 26, 2023
loloicci
added a commit
to loloicci/line-cosmwasm
that referenced
this pull request
Feb 6, 2024
This fix Finschia#338. And, this will be replaced with wasmparser in feature version. (CosmWasm/cosmwasm#1786)
loloicci
added a commit
to loloicci/line-cosmwasm
that referenced
this pull request
Feb 6, 2024
This fix Finschia#338. And, this will be replaced with wasmparser in feature version. (CosmWasm/cosmwasm#1786)
8 tasks
loloicci
added a commit
to Finschia/cosmwasm
that referenced
this pull request
Feb 7, 2024
* fix: enable sign ext This fix #338. And, this will be replaced with wasmparser in feature version. (CosmWasm/cosmwasm#1786) * Test contract compiled with Rust 1.70.0 * chore: update some contract's lock files * chore: update some contract's lock files --------- Co-authored-by: Simon Warta <simon@warta.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1735
I ported our validation code over to the wasmparser version reexported by wasmer.
Some of the errors have changed slightly because they are now thrown by wasmparser.
I am somewhat unsure about what
WasmFeatureswe want to have here.I set them a little more restrictive than what wasmer has (e.g. no simd, though we catch those in the gatekeeper anyways). This might allow some cases that were previously forbidden because of parity-wasm (e.g. bulk_memory or multi_value)