Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosmwasm_2_1 capability #2148

Merged
merged 4 commits into from
May 23, 2024
Merged

Add cosmwasm_2_1 capability #2148

merged 4 commits into from
May 23, 2024

Conversation

chipshort
Copy link
Collaborator

The feature was added before, but the capability was not.
I also added the feature in some more places where it's needed.

@webmaster128
Copy link
Member

Do we need this capability? See "What's a good capability?" in https://github.com/CosmWasm/cosmwasm/blob/main/docs/CAPABILITIES.md#whats-a-good-capability

@chipshort
Copy link
Collaborator Author

It is needed for the WriteAcknowledgement msg in #2130, since that will only be available for 2.1+ chains.

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the docs is misleading then

docs/CAPABILITIES-BUILT-IN.md Outdated Show resolved Hide resolved
@webmaster128 webmaster128 added this to the 2.1.0 milestone May 23, 2024
@chipshort chipshort merged commit f8505e8 into main May 23, 2024
29 of 31 checks passed
@chipshort chipshort deleted the cosmwasm_2_1-capability branch May 23, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants