Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress linter warning #2278

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Suppress linter warning #2278

merged 1 commit into from
Oct 7, 2024

Conversation

chipshort
Copy link
Collaborator

In latest Rust, this gets detected as unused. Adding #[cfg(test)] results in lots of changes through the codebase that don't really provide any benefit to readability, so let's just suppress the lint.

Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I also got a bunch more clippy lints on the latest nightly. I'll probably go through all of them some time.

@chipshort
Copy link
Collaborator Author

Yeah, I remember there were some more lints while I was using nightly, but this one has been annoying me for a while during releases. Time to get rid of it 😈

@chipshort chipshort merged commit 234e93e into main Oct 7, 2024
37 of 38 checks passed
@chipshort chipshort deleted the co/linter-warning branch October 7, 2024 10:47
@chipshort
Copy link
Collaborator Author

@Mergifyio backport release/2.2

Copy link
Contributor

mergify bot commented Oct 7, 2024

backport release/2.2

✅ Backports have been created

chipshort added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants