Migrate BLAKE3 to BLAKE2 for easier cross-compilation #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great. So the newest nightly breaks everything with lockfile v4. Cool cool. |
chipshort
reviewed
Oct 7, 2024
|
BLAKE3 had a handy output function that defaulted to 32 bytes, but the BLAKE2 crate by RustCrypto is variable output by default. They define a type alias that outputs a 512-bit hash, but rather have it explicit in the docs. |
|
@Mergifyio backport release/2.2 |
✅ Backports have been created
|
aumetra
added a commit
that referenced
this pull request
Oct 7, 2024
Migrate BLAKE3 to BLAKE2 for easier cross-compilation (backport #2279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2277
This also modifies the hash in the pathname to be 10 characters long instead of the full (would-be) 128 characters (which we could shorten to 64 characters by just outputting 32 bytes for the hash).
5 bytes should be fine for this usecase. This is the length of a Git short hash.