Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make App::store_code_with_creator deprecated #70

Closed
DariuszDepta opened this issue Sep 26, 2023 · 2 comments
Closed

Make App::store_code_with_creator deprecated #70

DariuszDepta opened this issue Sep 26, 2023 · 2 comments
Assignees
Labels
wontfix This will not be worked on
Milestone

Comments

@DariuszDepta
Copy link
Member

Since version 1.0 this function will be deprecated.

#[deprecated(since = "1.0", note = "use store_code instead")]
pub fn store_code_with_creator(&mut self, creator: Addr, code: Box<dyn Contract<CustomT::ExecT, CustomT::QueryT>>) -> u64

Instead this function, App::stor_code should be used as described in #69.

@DariuszDepta DariuszDepta added the API 1.0 Changes to API in version 1.0 label Sep 26, 2023
@DariuszDepta DariuszDepta added this to the 1.0.0 milestone Oct 2, 2023
@DariuszDepta DariuszDepta mentioned this issue Oct 6, 2023
DariuszDepta added a commit that referenced this issue Oct 6, 2023
@DariuszDepta DariuszDepta self-assigned this Oct 6, 2023
DariuszDepta added a commit that referenced this issue Oct 9, 2023
DariuszDepta added a commit that referenced this issue Oct 10, 2023
DariuszDepta added a commit that referenced this issue Oct 11, 2023
DariuszDepta added a commit that referenced this issue Oct 17, 2023
DariuszDepta added a commit that referenced this issue Oct 20, 2023
DariuszDepta added a commit that referenced this issue Oct 20, 2023
DariuszDepta added a commit that referenced this issue Nov 8, 2023
DariuszDepta added a commit that referenced this issue Nov 22, 2023
DariuszDepta added a commit that referenced this issue Nov 24, 2023
DariuszDepta added a commit that referenced this issue Nov 24, 2023
DariuszDepta added a commit that referenced this issue Nov 28, 2023
DariuszDepta added a commit that referenced this issue Dec 1, 2023
DariuszDepta added a commit that referenced this issue Dec 4, 2023
@DariuszDepta
Copy link
Member Author

Will be fixed in #78

DariuszDepta added a commit that referenced this issue Dec 12, 2023
@DariuszDepta DariuszDepta added wontfix This will not be worked on and removed API 1.0 Changes to API in version 1.0 labels Mar 5, 2024
@DariuszDepta
Copy link
Member Author

store_code stays untouched. store_code_with_creator does the trick - adds code with specific creator address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant