Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IntoAddr trait #138

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Added IntoAddr trait #138

merged 2 commits into from
Mar 8, 2024

Conversation

DariuszDepta
Copy link
Member

Added IntoAddr trait and refactored addresses.

@DariuszDepta DariuszDepta added this to the 1.0.0 milestone Mar 8, 2024
@DariuszDepta DariuszDepta self-assigned this Mar 8, 2024
@DariuszDepta DariuszDepta requested a review from jawoznia March 8, 2024 14:39
jawoznia
jawoznia approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/addresses.rs Outdated Show resolved Hide resolved
tests/test_api/test_bech32.rs Show resolved Hide resolved
@DariuszDepta DariuszDepta merged commit bf5ec95 into main Mar 8, 2024
7 checks passed
@DariuszDepta DariuszDepta deleted the into-addr-trait branch March 8, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawoznia jawoznia jawoznia approved these changes

Assignees

@DariuszDepta DariuszDepta

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DariuszDepta @jawoznia