Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Removed validation of empty attribute value #181

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Backport: Removed validation of empty attribute value #181

merged 1 commit into from
Jun 12, 2024

Conversation

DariuszDepta
Copy link
Member

closes #178

@DariuszDepta DariuszDepta self-assigned this Jun 12, 2024
@DariuszDepta DariuszDepta added this to the 1.2.0 milestone Jun 12, 2024
@DariuszDepta DariuszDepta requested a review from chipshort June 12, 2024 11:35
chipshort
chipshort approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DariuszDepta DariuszDepta mentioned this pull request Jun 12, 2024
Closed
@DariuszDepta DariuszDepta merged commit d540028 into release/1.2 Jun 12, 2024
6 of 7 checks passed
@DariuszDepta DariuszDepta deleted the backport-empty-string-attribute branch June 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

Assignees

@DariuszDepta DariuszDepta

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DariuszDepta @chipshort