Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring staking module, part 1 #185

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Refactoring staking module, part 1 #185

merged 6 commits into from
Jun 14, 2024

Conversation

DariuszDepta
Copy link
Member

@DariuszDepta DariuszDepta commented Jun 13, 2024 •
edited
Loading

  • Introduced constant BONDED_DENOM for staking token denominator.
  • Introduced constant YEAR (only in tests), containing length of 1 year expressed in seconds.
  • Simplified arguments passed to setup_test_env helper function.
  • Unified and renamed variable test_env to env in all tests (shorter name).
  • Unified local variable names in all test cases.

NO FUNCTIONAL CHANGES

@DariuszDepta DariuszDepta self-assigned this Jun 13, 2024
@DariuszDepta DariuszDepta added this to the 2.1.0 milestone Jun 13, 2024
@DariuszDepta DariuszDepta requested a review from aumetra June 13, 2024 15:15
aumetra
aumetra requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found this small nit about the year constant when skimming over the code

src/staking.rs Outdated Show resolved Hide resolved
@DariuszDepta DariuszDepta merged commit cf97411 into main Jun 14, 2024
7 checks passed
@DariuszDepta DariuszDepta deleted the refactoring-staking-part-1 branch June 14, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aumetra aumetra aumetra approved these changes

Assignees

@DariuszDepta DariuszDepta

Labels
refactor
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DariuszDepta @aumetra