Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring staking module, part 2 #186

Merged
merged 13 commits into from
Jun 17, 2024
Merged

Conversation

DariuszDepta
Copy link
Member

@DariuszDepta DariuszDepta commented Jun 14, 2024

  • The only functional change is, that StakeKeeper::new() calls now StakeKeeper::default() (idiomatic Rust).
  • Rest of the changes are only in test submodule, it is just optimizing/simplifying, unifying test code to be more readable and with less repetitive code. Code coverage stays the same, to be sure that nothing bad happened during this refactoring.

@DariuszDepta DariuszDepta added this to the 2.1.0 milestone Jun 14, 2024
@DariuszDepta DariuszDepta self-assigned this Jun 14, 2024
@DariuszDepta DariuszDepta requested a review from jawoznia June 14, 2024 13:35
Copy link
Contributor

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes to consider. LGTM

src/staking.rs Show resolved Hide resolved
src/staking.rs Show resolved Hide resolved
src/staking.rs Outdated Show resolved Hide resolved
@DariuszDepta DariuszDepta merged commit 9ed6977 into main Jun 17, 2024
5 checks passed
@DariuszDepta DariuszDepta deleted the refactoring-staking-part-2 branch June 17, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants