Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced todo! with unimplemented! #218

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Replaced todo! with unimplemented! #218

merged 1 commit into from
Oct 10, 2024

Conversation

DariuszDepta
Copy link
Member

According to this description from the official Rust documentation:
https://doc.rust-lang.org/std/macro.todo.html
replaced todo!() macros with unimplemented!() in documentation tests.

@DariuszDepta DariuszDepta self-assigned this Oct 10, 2024
@DariuszDepta DariuszDepta added this to the 2.2.0 milestone Oct 10, 2024
@DariuszDepta DariuszDepta requested a review from aumetra October 10, 2024 14:58
@DariuszDepta
Copy link
Member Author

Also some tools overinterpret this macro, example:

Zrzut ekranu z 2024-10-10 16-44-58

@DariuszDepta DariuszDepta merged commit 19eb52b into main Oct 10, 2024
7 checks passed
@DariuszDepta DariuszDepta deleted the replace-todo-with-unimplemented branch October 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aumetra aumetra aumetra approved these changes

Assignees

@DariuszDepta DariuszDepta

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DariuszDepta @aumetra