Add message SetWithdrawAddress to distribution module #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
LGTM
Personally I'd prefer to have a separate test case for that (in case you need to debug it in the future; it's better to have more specialized tests then couple monolithic ones), but I noticed that those tests weren't small ones to begin with so it's not a big deal.
|
@ueco-jb thanks for the review! i added an individual test for this as well. |
|
What are the chances we could see this in a release soon? |
|
@0xekez Could you rebase this? The conflict should be easy to fix and I'd love to get this merged. |
|
@chipshort rebased! let me know if there are any other changes you'd like to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on this I realized that there is no delegation module query type in cosmwasm-std. Would be interested in thoughts about adding that and what the proper ordering is.