Fix delegation queries #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The lint failure is unrelated to these changes |
chipshort
force-pushed
the
fix-delegation-queries
branch
from
d24febd to
2dd219d
Compare
ueco-jb
approved these changes
Mar 14, 2023
Comment on lines
-637
to
+702
| if amount > 0 { | ||
| if !amount.is_zero() { |
There was a problem hiding this comment.
This is the same, isn't it?
There was a problem hiding this comment.
Yes, it's the same. amount now is Uint128 instead of u128 and I don't like the look of amount > Uint128::zero() when there is an explicit function to check that.
| // save updated values | ||
| if shares.stake.is_zero() { | ||
| if shares.stake.is_zero() && unbonding.is_zero() { |
ethanfrey
reviewed
Mar 14, 2023
ethanfrey
reviewed
Mar 14, 2023
| delegator, | ||
| validator, | ||
| amount: amount.clone(), | ||
| can_redelegate: amount, // TODO: not implemented right now |
There was a problem hiding this comment.
Fair enough, not implemented properly in wasmd either
ethanfrey
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delegation queries should actually include the unbonding amounts. This should fix that behaviour.