Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes replace generic
Q
withEmpty
in such methods asContractWrapper::with_reply_empty
.We use shared testing mocks within different
App
types and custom modules. I only managed to do it having the PR changes. Here is an example. This line can be replaced with the next one to see the issue.Is there any reason to use generic
Q
instead ofEmpty
, which is used inContractWrapper::new_with_empty
, and any more elegant way to achieve that, or do these changes make sense?