Add extra close() tests in passing

CosmWasm · Sep 27, 2020 · 587c958 · 587c958
1 parent 5e948fd
commit 587c958
Showing 1 changed file with 28 additions and 4 deletions.
diff --git a/contracts/cw3-fixed-multisig/src/contract.rs b/contracts/cw3-fixed-multisig/src/contract.rs
@@ -889,7 +889,7 @@ mod tests {
             vote: Vote::Yes,
         };
         let env = mock_env(VOTER3, &[]);
-        let res = handle(&mut deps, env, vote).unwrap();
+        let res = handle(&mut deps, env.clone(), vote).unwrap();
 
         // Verify
         assert_eq!(
@@ -906,6 +906,19 @@ mod tests {
             }
         );
 
+        // In passing: Try to close Passed fails
+        let closing = HandleMsg::Close { proposal_id };
+        let res = handle(&mut deps, env, closing);
+
+        // Verify
+        assert!(res.is_err());
+        match res.unwrap_err() {
+            StdError::GenericErr { msg, .. } => {
+                assert_eq!(&msg, "Cannot close completed or passed proposals");
+            }
+            e => panic!("unexpected error: {}", e),
+        }
+
         // Execute works. Anybody can execute Passed proposals
         let env = mock_env(SOMEBODY, &[]);
         let res = handle(&mut deps, env.clone(), execution).unwrap();
@@ -923,6 +936,19 @@ mod tests {
                 data: None,
             }
         );
+
+        // In passing: Try to close Executed fails
+        let closing = HandleMsg::Close { proposal_id };
+        let res = handle(&mut deps, env, closing);
+
+        // Verify
+        assert!(res.is_err());
+        match res.unwrap_err() {
+            StdError::GenericErr { msg, .. } => {
+                assert_eq!(&msg, "Cannot close completed or passed proposals");
+            }
+            e => panic!("unexpected error: {}", e),
+        }
     }
 
     #[test]
@@ -1004,7 +1030,7 @@ mod tests {
             }
         );
 
-        // Close it again fails
+        // Trying to close it again fails
         let res = handle(&mut deps, env, closing);
 
         // Verify
@@ -1015,7 +1041,5 @@ mod tests {
             }
             e => panic!("unexpected error: {}", e),
         }
-
-        // TODO: Close Passed/Executed fails
     }
 }