Migrate to v0.11.0 #113
Merged
Migrate to v0.11.0 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest we "cross-review" this quickly once more, before merging it. Or are you OK with merging it directly? |
maurolacy
reviewed
Oct 10, 2020
| @@ -754,21 +771,21 @@ mod tests { | |||
| // fake a reinvestment (this must be sent by the contract itself) | |||
| // after this, we see 1000 issues and 1500 bonded (and a price of 1.5) | |||
| let rebond_msg = HandleMsg::_BondAllTokens {}; | |||
| let env = mock_env(&contract_addr, &[]); | |||
| let info = mock_info(MOCK_CONTRACT_ADDR, &[]); | |||
maurolacy
approved these changes
Oct 10, 2020
| @@ -450,19 +484,20 @@ fn query_all_approvals<S: Storage, A: Api, Q: Querier>( | |||
|
|
|||
| let res: StdResult<Vec<_>> = operators_read(&deps.storage, &owner_raw) | |||
| .range(start.as_deref(), None, Order::Ascending) | |||
| .filter(|r| include_expired || r.is_err() || !r.as_ref().unwrap().1.is_expired(&env.block)) | |||
There was a problem hiding this comment.
Including errors just in case... shouldn't happen, but makes sense.
| let mut late_env = mock_env(); | ||
| late_env.block.height = 1234568; //expired | ||
| let res = query_all_approvals(&deps, late_env, "person".into(), false, None, None).unwrap(); | ||
| assert_eq!(0, res.operators.len()); |
There was a problem hiding this comment.
Nice. We can add exhaustive test cases later.
|
Yeah, happy if we both do one more review on this before merging. Looks like you already did I will by Monday |
ethanfrey
commented
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
Making a PR for Mauro, including my work (previously merged) as well.
Updates all contracts to cosmwasm v0.11.0