Use Include/Exclude Bounds to define range searches #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK. Even though you already merged it, I'll review the other MR (storage-maps) first, as it will help me gain more context. |
maurolacy
approved these changes
Oct 12, 2020
packages/storage-plus/src/prefix.rs
Outdated
| #[derive(Copy, Clone, Debug)] | ||
| pub enum Bound<'a> { | ||
| Include(&'a [u8]), | ||
| Exclude(&'a [u8]), |
There was a problem hiding this comment.
Maybe Inclusive / Exclusive (like in inclusive / exclusive bounds) are better names here.
|
Migrating cw3-fixed-multisig is a bigger task than I thought, as I need/want to add support for u64 keys natively and not force &id.as_be_bytes() everywhere, but provide a cleaner interface. This is a big boon to the API, but more work than I want to throw in this PR. Will tackle that as a follow up |
This was referenced Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is what you were suggesting Mauro - public API doesn't require bit-twiddling.
This is incomplete and definitely missing tests, but please review the idea (and maybe suggest a better path forward).
When we agree on a proper interface and implement it, then I will use the new
ItemandMapandPrefix/Boundtypes to reimplement the storage ofcw3-fixed-multisigas a real world test case.cw3-fixed-multisigto new API (Migrate cw3-fixed-multisig #119)Once this is out, I would love to cut a
0.3.0release, and then we can add secondary indexes in0.3.1as a non-breaking change