Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CanSend to CanExecute for generality #146

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Rename CanSend to CanExecute for generality #146

merged 3 commits into from
Nov 30, 2020

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Nov 28, 2020 •
edited
Loading

Closes the first part of #145, renaming of CanSend query enum and associated methods.

Will implement the seconds part, i. e. modifying CanExecute params, in a follow-up PR against this branch, for ease of reviewing.

@maurolacy maurolacy requested a review from ethanfrey November 28, 2020 08:44
@maurolacy maurolacy self-assigned this Nov 28, 2020
ethanfrey
ethanfrey approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

please revert the version bump, then feel free to merge yourself.

contracts/cw1-subkeys/Cargo.toml Outdated Show resolved Hide resolved
@maurolacy maurolacy merged commit 3ec4e8b into master Nov 30, 2020
@maurolacy maurolacy deleted the cw1-rename-can_send branch November 30, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@orkunkl orkunkl Awaiting requested review from orkunkl

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurolacy @ethanfrey