Separate multisig from group #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
This is pretty good. I am amazed at how using the right abstractions simplifies the code and increases readability.
I was expecting cross-contract queries to be much more of an issue. This is as clear a build-up on top of fixed-multisig as possible.
Will review the tests later, and add single comments in any case.
Co-authored-by: Mauro Lacy <maurolacy@users.noreply.github.com>
ethanfrey
force-pushed
the
separate-multisig-from-group
branch
from
7f51929 to
cd51d9c
Compare
|
I think I have addressed all outstanding issues. Just waiting for a review of the test code to merge this. |
maurolacy
reviewed
Dec 4, 2020
maurolacy
reviewed
Dec 4, 2020
maurolacy
reviewed
Dec 4, 2020
|
Nice translation of all the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80
This no longer stores the members locally (in contract), but uses raw queries to read them from an associated group.
The code changes were relatively small. The tests must be completely re-written to use multi-test. Notably, this was even a couple lines of code shorter after the refactor. And that using multiple contracts in a much more complicated test harness.
In the end, this works the same as the
cw3-fixed-multisig, but opens the door for all the other mutlisig ticketsThe first two commits are quite huge and just make a clone of cw3-fixed-multisig as a new contract. To review, you can just check all commits after the first two, and make sure to expand
contract.rs, which is where most of the changes are: https://github.com/CosmWasm/cosmwasm-plus/pull/150/files/2a70c8baea7dfe534f136cff1bfa20b3485128fa..HEAD