Add cw4 hooks #156
Merged
Add cw4 hooks #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
force-pushed
the
add-cw4-hooks
branch
from
517f077 to
fe3512e
Compare
This was referenced Dec 4, 2020
maurolacy
approved these changes
Dec 6, 2020
Comment on lines
+93
to
+97
| let mut ctx = Context::new(); | ||
| for h in HOOKS.may_load(deps.storage)?.unwrap_or_default() { | ||
| let msg = diff.clone().into_cosmos_msg(h)?; | ||
| ctx.add_message(msg); | ||
| } |
There was a problem hiding this comment.
Nice, this would be similar to creating a msgs which is a Vec<CosmosMsg>, and attaching it to a HandleResponse.
There was a problem hiding this comment.
Exactly, the Context was made to make that look a bit nicer.
Jury still a bit out if it is better, but happy for opinions.
There was a problem hiding this comment.
Maybe it's because I'm just used to it, but I like the other variant better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140