Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token weighted group #167

Merged
merged 22 commits into from
Dec 14, 2020
Merged

Token weighted group #167

merged 22 commits into from
Dec 14, 2020

Conversation

ethanfrey
Copy link
Member

Closes #142

@ethanfrey ethanfrey marked this pull request as ready for review December 11, 2020 12:03
@ethanfrey ethanfrey force-pushed the token-weighted-group branch 2 times, most recently from 5634dd3 to b99b3e9 Compare December 11, 2020 16:51
@ethanfrey
Copy link
Member Author

ethanfrey commented Dec 11, 2020 •
edited
Loading

This should be complete.

I would like to merge it in before any other general repo refactoring comes in, so this contract also gets in that

@ethanfrey ethanfrey requested a review from maurolacy December 11, 2020 21:26
@ethanfrey ethanfrey force-pushed the token-weighted-group branch from 0e448b8 to 7ed5908 Compare December 11, 2020 21:44
@maurolacy
Copy link
Contributor

Currently reviewing.

maurolacy
maurolacy reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a review of all the changes in the PR, except for the cw4-stake ones.

Releasing it now so you can take a look at it. Will specifically review cw4-stake in a follow-up.

packages/cw4/README.md Outdated Show resolved Hide resolved
packages/cw4/README.md Show resolved Hide resolved
packages/cw4/src/hook.rs Outdated Show resolved Hide resolved
packages/cw0/src/hooks.rs Show resolved Hide resolved
contracts/cw4-group/README.md Outdated Show resolved Hide resolved
contracts/cw4-group/src/helpers.rs Show resolved Hide resolved
contracts/cw4-group/src/helpers.rs Outdated Show resolved Hide resolved
contracts/cw4-group/src/error.rs Show resolved Hide resolved
contracts/cw4-group/src/contract.rs Show resolved Hide resolved
contracts/cw3-flex-multisig/src/contract.rs Outdated Show resolved Hide resolved
@maurolacy maurolacy self-requested a review December 14, 2020 11:31
@ethanfrey
Copy link
Member Author

Thanks for the feedback, I will do the general cleanup. Happy to see your review on cw4-stake when you get to it.

maurolacy
maurolacy approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cw4-stake looks good to me. Will take a detailed look at the tests later, and eventually add single comments.

contracts/cw4-stake/README.md Outdated Show resolved Hide resolved
contracts/cw4-stake/README.md Outdated Show resolved Hide resolved
contracts/cw4-stake/src/lib.rs Outdated Show resolved Hide resolved
contracts/cw4-stake/src/msg.rs Outdated Show resolved Hide resolved
contracts/cw4-stake/src/msg.rs Outdated Show resolved Hide resolved
packages/cw0/src/claim.rs Outdated Show resolved Hide resolved
packages/cw0/src/claim.rs Outdated Show resolved Hide resolved
packages/cw0/src/claim.rs Outdated Show resolved Hide resolved
packages/cw0/src/claim.rs Show resolved Hide resolved
contracts/cw4-stake/src/contract.rs Outdated Show resolved Hide resolved
@ethanfrey
Copy link
Member Author

Nice comments, thank you for the thorough review

@ethanfrey ethanfrey merged commit 5b4dfd7 into master Dec 14, 2020
@ethanfrey ethanfrey deleted the token-weighted-group branch December 14, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add token-weighted group
2 participants
@ethanfrey @maurolacy