Cw20 bonding deterministic #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-determinism (I64ReinterpretF64 / F64ConvertI64U ops) was caused by the use of the `num-integer` crate. Replaced it by a couple of crates for integer sqrt and cbrt.
maurolacy
force-pushed
the
cw20-bonding-deterministic
branch
from
e095693 to
6d95f49
Compare
maurolacy
force-pushed
the
cw20-bonding-deterministic
branch
from
6d95f49 to
fefbba0
Compare
|
Nice find with the crates. Not just where it came from (me blindly trusting crates with name "integer" not to include floating point ops), but finding alternatives. Looks like it is just a CI bug. Happy if you want to do #228 first and then rebase this using that CI when it is ready. It makes me happy to know you have a solution you tested locally 😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #227.
Non-determinism (
I64ReinterpretF64/F64ConvertI64Uoperators) was caused by the use ofthe
num-integercrate.Replaced it by a couple of crates for integer sqrt and integer cbrt.