Fix ics20 denom #244
Merged
Fix ics20 denom #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
approved these changes
Mar 12, 2021
| @@ -130,6 +131,17 @@ pub fn execute_transfer( | |||
| Ok(res) | |||
| } | |||
|
|
|||
| #[cfg_attr(not(feature = "library"), entry_point)] | |||
| pub fn migrate(deps: DepsMut, _env: Env, _msg: MigrateMsg) -> Result<Response, ContractError> { | |||
There was a problem hiding this comment.
🤗 Makes debugging for me so much easier
| if split_denom.len() != 3 { | ||
| return Err(ContractError::NoForeignTokens {}); | ||
| } | ||
| // a few more sanity checks |
There was a problem hiding this comment.
It makes sense to check all part. 👍
| Ok(msg) => { | ||
| // build attributes first so we don't have to clone msg below | ||
| // similar event messages like ibctransfer module | ||
|
|
||
| // This cannot fail as we parse it in do_ibc_packet_receive. Best to pass the data somehow? | ||
| let denom = parse_voucher_denom(&msg.denom, &packet.src).unwrap(); |
There was a problem hiding this comment.
Parsing errors should be app level and stored with the event attribute. I may have run into this with an old state and could not read the event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle parsing the voucher's denom when it is returned to us.
Thanks @alpe for finding this
port/channel/orig_denomAlso add a migrate entry point that accepts any older cw20-ics20 contract as a migration target.