Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle msg to execute msg #250

Merged
merged 7 commits into from
Mar 29, 2021
Merged

Handle msg to execute msg #250

merged 7 commits into from
Mar 29, 2021

Conversation

maurolacy
Copy link
Contributor

Closes #236.

@maurolacy maurolacy requested a review from ethanfrey March 22, 2021 10:31
@maurolacy maurolacy self-assigned this Mar 22, 2021
@maurolacy maurolacy mentioned this pull request Mar 22, 2021
Merged
ethanfrey
ethanfrey approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

PATTERNS.md Show resolved Hide resolved
contracts/cw20-ics20/src/ibc.rs
@@ -12,7 +12,7 @@ use cosmwasm_std::{
use crate::amount::Amount;
use crate::error::{ContractError, Never};
use crate::state::{ChannelInfo, CHANNEL_INFO, CHANNEL_STATE};
use cw20::Cw20HandleMsg;
use cw20::Cw20ExecuteMsg;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to rename this as well

packages/cw1/src/msg.rs Show resolved Hide resolved
@ethanfrey ethanfrey merged commit 97b26e9 into master Mar 29, 2021
@ethanfrey ethanfrey deleted the HandleMsg-to-ExecuteMsg branch March 29, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename HandleMsg to ExecuteMsg
2 participants
@maurolacy @ethanfrey