PartialEq for errors #253
Merged
PartialEq for errors #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
reviewed
Mar 29, 2021
There was a problem hiding this comment.
Looks good and improves a lot of tests.
However, I had some questions on what the canonical format for checking StdError types is and let us just define one pattern and stick to it (I see 2 approached above).
Other that that, just a rebase to fix merge conflicts and this is good to merge.
ethanfrey
approved these changes
Mar 30, 2021
maurolacy
force-pushed
the
partialeq-for-errors
branch
from
c558087 to
f5a671d
Compare
Standardize error args order Add extra matches! / error builders
|
Merging now, so as to integrate with the other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179.