Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid the need for Any type by using Empty as message type and String as error type #281

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Avoid the need for Any type by using Empty as message type and String as error type #281

merged 3 commits into from
Apr 21, 2021

Conversation

webmaster128
Copy link
Member

No description provided.

@webmaster128 webmaster128 requested a review from ethanfrey April 21, 2021 13:21
ethanfrey
ethanfrey approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and better solution.

@webmaster128 webmaster128 mentioned this pull request Apr 21, 2021
Closed
@webmaster128 webmaster128 merged commit 02335fe into master Apr 21, 2021
@webmaster128 webmaster128 deleted the input-output-types branch April 21, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @ethanfrey